search

wfondrie / mokapot

Fast and flexible semi-supervised learning for peptide detection in Python
https://mokapot.readthedocs.io
Apache License 2.0
40 stars 14 forks source link

Fix missing values caused by logging #60

Closed wfondrie closed 1 year ago

wfondrie commented 1 year ago

@cia23 saw missing values when trying to parse PepXML results, seemingly caused by log-transforming features with zeros in them. This patch changes the behavior to only log-transform features with values > 0.

codecov-commenter commented 1 year ago

Codecov Report

Merging #60 (09f52ca) into master (bca014d) will increase coverage by 0.24%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   83.24%   83.49%   +0.24%     
==========================================
  Files          18       18              
  Lines        1552     1551       -1     
==========================================
+ Hits         1292     1295       +3     
+ Misses        260      256       -4
Impacted Files Coverage Δ
mokapot/parsers/pepxml.py 92.53% <100.00%> (+2.90%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bca014d...09f52ca. Read the comment docs.