wfondrie / mokapot

Fast and flexible semi-supervised learning for peptide detection in Python
https://mokapot.readthedocs.io
Apache License 2.0
40 stars 14 forks source link

Fixed need for intercept #62

Closed wfondrie closed 1 year ago

wfondrie commented 1 year ago

This PR resolves Issue #61 and does a little bit of cleaning in the mokapot.brew() function.

The CV fold that mokapot.Model() objects are fit to is now recorded during the fitting process. This means we can successfully recover the order of trained models using the recorded folds.

codecov-commenter commented 1 year ago

Codecov Report

Merging #62 (74251d5) into master (bca014d) will increase coverage by 0.92%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   83.24%   84.16%   +0.92%     
==========================================
  Files          18       18              
  Lines        1552     1554       +2     
==========================================
+ Hits         1292     1308      +16     
+ Misses        260      246      -14     
Impacted Files Coverage Δ
mokapot/config.py 91.30% <ø> (ø)
mokapot/brew.py 90.47% <100.00%> (+1.05%) :arrow_up:
mokapot/model.py 86.93% <100.00%> (+3.09%) :arrow_up:
mokapot/mokapot.py 93.90% <0.00%> (+8.53%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bca014d...74251d5. Read the comment docs.