wfu-dmds / teaching-r-study

3 stars 2 forks source link

Final changes to survey #11

Closed LucyMcGowan closed 3 years ago

LucyMcGowan commented 3 years ago
jdtrat commented 3 years ago

Oops -- didn't mean to close this.

jdtrat commented 3 years ago

@LucyMcGowan Do you know how to get rid of the "Previous Topic" button from the learnr modules? I haven't come across anything that would help with that (pictured is the end of assessment 3).

Screen Shot 2021-02-04 at 8 45 15 PM

LucyMcGowan commented 3 years ago

I don’t & last time I looked it was hard coded in. I think it’s fine to leave it and just add a “I’m finished with the course” button - they may want to go back before they decide they’re finished for example

jdtrat commented 3 years ago

Fair! I have only figured out how to place a "Finish Survey" button above that. Do you think that's okay? If not, what would you suggest? (I'm sure we can change the CSS of that button).

Screen Shot 2021-02-04 at 9 20 01 PM

LucyMcGowan commented 3 years ago

Above is great!

jdtrat commented 3 years ago

This is what I'm thinking. For whatever reason, onclick will not work, so I have another modal pop up that won't go away. Upon submission, a .rds file gets uploaded with a tibble containing the username and email. Let me know if I should push the changes or change anything!

complete_session

LucyMcGowan commented 3 years ago

This looks great to me, thanks!

jdtrat commented 3 years ago

Changing usernames to 150 should be done right before launch (as they will get used if we are still testing it). We should all test the urls/survey more formally, but from what I can tell they all work!

jdtrat commented 3 years ago

You can run through the task here: http://wfudatasciencelab.shinyapps.io/learnr-consent/

nuripark10 commented 3 years ago

There is an error in tidy_reading data module. For the exercise where the solution is "read_csv("data/airquality.csv"))", I get an error "cannot open the connection to 'https://raw.githubusercontent.com/wfu-dmds/teaching-r-study/master/learnr-module/data/airquality.csv'"

nuripark10 commented 3 years ago
  1. Solutions are visible for exercises in tidy modules. Did we mean it?
  2. Tidy manipulating module -> pipe exercise "Using the flights data, find the the flights average distance grouped by year, origin, dest, and arr_delay." -> answer is correct but module says it is wrong.
LucyMcGowan commented 3 years ago

@nuripark10, I've fixed the first issue (with reading in the airquality data). What do you mean the solutions are visible for the exercises in tidy modules? I didn't see the solutions, but maybe I've missed something! For (3), what answer did you try? I did:

flights %>% 
  filter(arr_delay <= 120) %>%
  select(dep_time, sched_dep_time)

And it worked.