Closed D4KU closed 2 years ago
I would recommend documenting them as a part of this PR. It helps me test when I’m implementing them in fish!
On Wed, Jul 7, 2021 at 12:23 PM, David Kutschke @.***> wrote:
Check list
- I have performed a self-review of my code
- I have commented my code in hard-to-understand areas
- I have made corresponding changes to the documentation
Description
Added two new bash/zsh commands to:
- checkout selected files from given branch
- stash selected files
I didn't add them to the readme. My thinking was that it's probably better to document them only when implemented in fish.
Type of change
- Bug fix
- New feature
- Refactor
- Breaking change
- Documentation change
Test environment
Shell
bash
zsh
fish
OS
Linux
Mac OS X
Windows
Others:
You can view, comment on, or merge this pull request online at:
https://github.com/wfxr/forgit/pull/157
Commit Summary
- Added command to checkout file from branch
- Added command to push files on stash
- Simplified checkout file from branch
File Changes
- M forgit.plugin.zsh (51)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.
That makes sense. I added them to the readme.
@wfxr pinging for a review when you get a chance
@wfxr I would say I support this coming in. Especially if @D4KU had time to add a git stash apply or git stash show for feature symmetry.
Hold off until @wfxr approves, just to be sure we want to take this. I give this change a big thumbs up, though :)
Especially if @D4KU had time to add a git stash apply or git stash show for feature symmetry.
No problem at all. :)
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Check list
Description
Added two new bash/zsh commands to:
I didn't add them to the readme. My thinking was that it's probably better to document them only when implemented in fish.
Type of change
Test environment