use fish to interpret preview command

wfxr / forgit

:zzz: A utility tool powered by fzf for using git interactively.

MIT License

4.4k stars 137 forks source link

use fish to interpret preview command #169

Closed p00f closed 2 years ago

p00f commented 2 years ago

fixes #168

Check list

[x] I have performed a self-review of my code
[x] I have commented my code in hard-to-understand areas
[x] I have made corresponding changes to the documentation

Description

See https://github.com/wfxr/forgit/issues/168#issue-1064088027

Type of change

[x] Bug fix
[ ] New feature
[ ] Refactor
[ ] Breaking change
[ ] Documentation change

Test environment

Shell
- [ ] bash
- [ ] zsh
- [x] fish
OS
- [x] Linux
- [ ] Mac OS X
- [ ] Windows
- [ ] Others:

wfxr commented 2 years ago

@p00f LGTM. Thanks for your contribution !

cjappl commented 2 years ago

This seems to be the root cause of #170

I'm going to revert this change for now, as I feel this is a bit of a strange workflow.

Absolutely open to fixes for this, but unfortunately this one causes a big breakage on latest fish!!

p00f commented 2 years ago

@cjappl I applied this patch again, it works on fish 3.3.1 :/

cjappl commented 2 years ago

Can you try it in a shell with both interactive and user shells are fish?

That was my config in which it wasn’t working, see the details in #170

Let me know. Definitely down to get to the bottom of this :)

On Mon, Jan 3, 2022 at 9:17 PM, Chinmay Dalal @.***> wrote:

@.***(https://github.com/cjappl) I applied this patch again, it works on fish 3.3.1 :/

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: @.***>