Fix for: ga preview not working with fish

[cjappl]

Closes #170

Check list

• [x] I have performed a self-review of my code
• [x] I have commented my code in hard-to-understand areas
• [x] I have made corresponding changes to the documentation

Description

Type of change

• [x] Bug fix

Test environment

• Shell
  • [x] fish
• OS
  • [x] Mac OS X

[cjappl]

@wfxr would you double check this. Is there a case in which we expect this to be surrounded by double quotes? I removed it and there was no issue, so wondering why it was there in the first place

[wfxr]

@wfxr would you double check this. Is there a case in which we expect this to be surrounded by double quotes? I removed it and there was no issue, so wondering why it was there in the first place

When the file path contains spaces like this:

touch foo.txt 'foo bar.txt'
git status -s

[cjappl]

Thanks I’ll double check this tomorrow morning and make sure it works.

On Wed, Dec 1, 2021 at 6:35 PM, Wenxuan @.***> wrote:

@.***(https://github.com/wfxr) would you double check this. Is there a case in which we expect this to be surrounded by double quotes? I removed it and there was no issue, so wondering why it was there in the first place

When the file path contains spaces like this:

touch foo.txt

'

foo bar.txt

'

git status -s

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[cjappl]

Alright, this breaks spaces in file names but I've tried for a few hours and I can't fix it.

I'm going to reach out for help on the fish project page and see if anyone can see what my issue is. Something with the way fish deals with single and double quotes. I will keep you posted

[cjappl]

Merging this for now, as I think this problem is bigger than the files with spaces in them issue