fix: gd show empty preview when path has spaces

wfxr / forgit

:zzz: A utility tool powered by fzf for using git interactively.

MIT License

4.33k stars 136 forks source link

fix: gd show empty preview when path has spaces #204

Closed wfxr closed 2 years ago

wfxr commented 2 years ago

Check list

[x] I have performed a self-review of my code
[x] I have commented my code in hard-to-understand areas
[x] I have made corresponding changes to the documentation

Description

See #203

Type of change

[x] Bug fix
[ ] New feature
[ ] Refactor
[ ] Breaking change
[ ] Documentation change

Test environment

Shell
- [x] bash
- [x] zsh
- [ ] fish
OS
- [ ] Linux
- [x] Mac OS X
- [ ] Windows
- [ ] Others:

wfxr commented 2 years ago

@cjappl Can you help fix the fish part?

cjappl commented 2 years ago

I'm going to merge this, as I tried for a bit yesterday to fix in fish and was having issues.

Made #206 to track it. I noticed that this issue happens in both gd and ga for fish, you should check that ga doesn't have this problem as well in zsh.

wfxr commented 2 years ago

Thank you @cjappl.

I noticed that this issue happens in both gd and ga for fish, you should check that ga doesn't have this problem as well in zsh.

ga works as expected in zsh:

max-ae commented 2 years ago

Thanks for the fix! However, the following issue is now present: relative paths do not show anymore in gd fzf selection list.

Consider the following directory structure: foo/bar/file

Working directory is bar, file has changes.

ga lists file, while gd lists foo/bar/file