wfxr / forgit

:zzz: A utility tool powered by fzf for using git interactively.
MIT License
4.33k stars 136 forks source link

Parse error after new installation #205

Closed lastcoolnameleft closed 1 year ago

lastcoolnameleft commented 2 years ago

Check list

Environment info

Problem / Steps to reproduce

My scenario:

cjappl commented 2 years ago

Assigning to @wfxr

rablador commented 1 year ago

Having the same setup and same error.

cjappl commented 1 year ago

EDIT: Sorry, this was a response to another ticket that got scrambled somehow. please disregard

dykwok commented 1 year ago

@lastcoolnameleft , @cjappl you can check your .gitconfig settings, and set "pager" as pager = less -FRSX. It works for me.

rablador commented 1 year ago

Still same problem for me :/

cjappl commented 1 year ago

@carlfriedrich any ideas here?

carlfriedrich commented 1 year ago

No concrete idea, but @lastcoolnameleft @rablador can you maybe checkout my branch from #241 and see if the error appears there as well?

rablador commented 1 year ago

Running git forgit from the branch "move-implementation-to-standalone-forgit", with PATH pointing to the bin folder yields:

git-forgit: line 526: forgit: command not found

carlfriedrich commented 1 year ago

@rablador Thanks for your feedback. What was the exact command that you tried? git forgit alone doesn't do anything, since we need to provide a forgit subcommand like git forgit log. But nevertheless git forgit alone should provide a useful error message, I will add a patch for that.

rablador commented 1 year ago

Ah, right, I forgot to add a command! It works! :D

carlfriedrich commented 1 year ago

@rablador Great, so the error from this issue is gone on the new branch? We will merge this in the next few days, so then the issue should be solved in master as well.

@lastcoolnameleft What about you, can you verify this in your environment?

rablador commented 1 year ago

@carlfriedrich Yeah, from the branch "move-implementation-to-standalone-forgit" everything works as expected as long as I supply a command for git forgit. :)

carlfriedrich commented 1 year ago

@rablador Great, thank you. I already added a commit to the branch which displays a useful error message if no or an invalid command is given, so that shouldn't be a problem anymore either. :-)

carlfriedrich commented 1 year ago

241 has been merged, so after the feedback from @rablador I am considering this fixed. If anyone still has this problem, please open a new issue.