wfxr / forgit

:zzz: A utility tool powered by fzf for using git interactively.
MIT License
4.33k stars 136 forks source link

Fish bug: some of the commands (glo, gss) don't work #208

Closed radiden closed 1 year ago

radiden commented 2 years ago

Check list

Environment info

Problem / Steps to reproduce

Run glo or gss in fish. Instead of getting fzf the shell hangs, after pressing random buttons the cursor disappears, until Ctrl+C is hit. Other commands seem to work fine.

Versions:

git version 2.36.0
fzf 0.30.0 (tarball)
fish, version 3.4.1
endigma commented 2 years ago

can reproduce void linux & nix latest

cjappl commented 2 years ago

Hi @endigma ,

Thanks for the report!! Unfortunately I don't have a linux box to test and fix with, is there any way you could submit a PR if you get to the bottom of it?

On my OSX machine, these commands are working as intended. (see screenshots below)

$ git --version
git version 2.34.1
$ fish --version
fish, version 3.1.2
$ fzf --version
0.25.1 (brew)

glo:

Screen Shot 2022-05-30 at 11 27 19 AM

gss:

Screen Shot 2022-05-30 at 11 28 58 AM
endigma commented 2 years ago

you should try https://github.com/lima-vm/lima

jgoldhammer commented 2 years ago

I can reproduce that glo hangs under macos. I am using following versions:

fzf --version
0.30.0 (brew)

fish --version
fish, version 3.5.0

git --version
git version 2.36.1
endigma commented 2 years ago
fzf --version
0.30 (devel)

fish --version
fish, version 3.4.1

git --version
git version 2.36.1

can reproduce still

cjappl commented 2 years ago

I would fully support a PR to help fix this! Unfortunately I can't repro so I am not of help. If anyone wants to step up, happy to help review 😄

goncharov commented 1 year ago

I faced the same issue after installation of oh-my-fish/plugin-grc. It overrides env command. As workaround I've excluded env to override by set -U grc_plugin_ignore_execs env

endigma commented 1 year ago

I faced the same issue after installation of oh-my-fish/plugin-grc. It overrides env command. As workaround I've excluded env to override by set -U grc_plugin_ignore_execs env

This is the fix.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.