glo and ga incorrectly display terminal color codes

[phillipreeder]

Check list

• [X] I have read through the README
• [X] I have the latest version of forgit
• [X] I have searched through the existing issues

Environment info

• OS
  • [ ] Linux
  • [X] Mac OS X
  • [ ] Windows
  • [ ] Others:
• Shell
  • [ ] bash
  • [X] zsh
  • [ ] fish

Problem / Steps to reproduce

Using fzf 0.30.0 and forgit 98a5cc2 displays terminal color codes instead of actually rendering the colors for the glo and ga commands. This prevents the commit from loading correctly in preview.

[wfxr]

@phillipreeder Can you update forgit and try again? I cannot repro:

[phillipreeder]

Now on 492ae8 and still having issues. This is with iTerm2 and oh-my-zsh.

[wfxr]

@phillipreeder Can you run the following command to see if fzf is working properly?

echo -e "\e[32mRed text\e[0m" | fzf --ansi

[phillipreeder]

Output of 32m and 31m

[wfxr]

Weird...your fzf seems ok to render the ansi colors. Have you modified the --ansi option for fzf?

https://github.com/wfxr/forgit/blob/bd8fce74a662fd6ed90d942a797531ffd0492ae8/forgit.plugin.zsh#L416

[phillipreeder]

~ ❯ echo $FZF_DEFAULT_OPTS
--layout=reverse
~ ❯ echo $FORGIT_FZF_DEFAULT_OPTS
--exact --border --cycle --reverse --height '80%'

[wfxr]

~ ❯ echo $FORGIT_FZF_DEFAULT_OPTS
--exact --border --cycle --reverse --height '80%'

@phillipreeder $FORGIT_FZF_DEFAULT_OPTS seems to be overwritten by your custom config. You should make sure to set all the options of forgit before it is sourced.

[phillipreeder]

That did the trick, moving configs to before sourcing forgit solved the issue. Thanks!