Add variable "forgit_extract_sha"

carlfriedrich commented 1 year ago

This was a requested change from @cjappl as part of #219. Since we're not merging that PR, I'm submitting this separately, because I find it really useful for the code consistency.

There was also a tiny bug left for git::cherry_pick, where the SHA was not correctly parsed if FORGIT_LOG_GRAPH_ENABLE was set to false. I fixed this on the way, since it was the only command that parsed the SHA differently than the other commands.

I also included the tr -d [:space:] part in the variable, which is only used for copying the SHA to the clipboard but shouldn't cause trouble in the other use cases. @wfxr Can you check if copying still works correctly?

Check list

[x] I have performed a self-review of my code
[x] I have commented my code in hard-to-understand areas
[x] I have made corresponding changes to the documentation

Description

Type of change

[ ] Bug fix
[ ] New feature
[x] Refactor
[ ] Breaking change
[ ] Documentation change

Test environment

Shell
- [x] bash
- [x] zsh
- [x] fish
OS
- [x] Linux
- [ ] Mac OS X
- [ ] Windows
- [ ] Others:

cjappl commented 1 year ago

You're a PR machine!! Also really appreciate you doing both shells at once, 👍 👍

change looks good to me, will leave it to @wfxr to officially approve

carlfriedrich commented 1 year ago

@cjappl Just trying to improve some piece of software that I really enjoy using. Won't be my last PR. :-) And I really appreciate that you both are so supportive concerning external PRs. That's not the case on every open source project.

cjappl commented 1 year ago

Love it!

Hey the more work others do, the less wfxr and I need to do. ;)

“Many hands make light work”!! We really appreciate the submissions.

On Wed, Jul 27, 2022 at 3:00 AM, Tim @.***> wrote:

@.***(https://github.com/cjappl) Just trying to improve some piece of software that I really enjoy using. Won't be my last PR. :-) And I really appreciate that you both are so supportive concerning external PRs. That's not the case on every open source project.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

wfxr commented 1 year ago

@carlfriedrich Thank you! This makes the code cleaner! I tested in zsh and it works good.

wfxr / forgit