wfxr / forgit

:zzz: A utility tool powered by fzf for using git interactively.
MIT License
4.33k stars 136 forks source link

grb: rebase on parent of the selected commit #223

Closed carlfriedrich closed 1 year ago

carlfriedrich commented 1 year ago

The git rebase command needs to be passed the parent commit of the one you want to edit. When selecting a commit interactively via fzf, it makes sense to automatically pass the parent commit of the selected one. Within fzf it's otherwise quite hard to find the parent commit by hand if you have found your commit via an fzf search string.

Check list

Description

Type of change

Test environment

carlfriedrich commented 1 year ago

Hmm, some of the checks fail, but it doesn't seem that it's my commit's fault. Seems I cannot restart the checks. @wfxr @cjappl Can you?

wfxr commented 1 year ago

@carlfriedrich Looks like there's something wrong with the fish's ppa in ci. Just ignore it.

wfxr commented 1 year ago

@carlfriedrich Nice improvement! Thanks for your contribution!

carlfriedrich commented 1 year ago

@wfxr Oh, now actually shellcheck reported a real issue. Shall we fix that?

wfxr commented 1 year ago

@carlfriedrich Just a tiny issue. Fixed in https://github.com/wfxr/forgit/commit/85ccdd3f809d9e9892403a631f980406d4a278c6 .

carlfriedrich commented 1 year ago

@wfxr Great, thanks a lot!