fix: forgit::log can not match files - Githubissues

wfxr / forgit

:zzz: A utility tool powered by fzf for using git interactively.

MIT License

4.32k stars 136 forks source link

fix: forgit::log can not match files #249

Closed ZenLian closed 1 year ago

ZenLian commented 1 year ago

Check list

[x] I have performed a self-review of my code
[x] I have commented my code in hard-to-understand areas
[x] I have made corresponding changes to the documentation

Description

Bug: glo -- files should show specified files only, but instead it shows all changed files. Fix: There is a redundent blank in sed regex.

Type of change

[x] Bug fix
[ ] New feature
[ ] Refactor
[ ] Breaking change
[ ] Documentation change

Test environment

Shell
- [x] bash
- [x] zsh
- [ ] fish
OS
- [x] Linux
- [ ] Mac OS X
- [ ] Windows
- [ ] Others:

carlfriedrich commented 1 year ago

@ZenLian Thanks for your PR! We just merged a significant change which conflicts with your patch. Can you rebase this on current master?

ZenLian commented 1 year ago

@carlfriedrich Rebase done. Sorry for my late reply.

cjappl commented 1 year ago

Seeing as @wfxr has been busy recently, I think we should consider merging this! What do you think @carlfriedrich ?