fix: compatibility check not working in bash

wfxr / forgit

:zzz: A utility tool powered by fzf for using git interactively.

MIT License

4.32k stars 136 forks source link

fix: compatibility check not working in bash #258

Closed gbtec-markusmeier closed 1 year ago

gbtec-markusmeier commented 1 year ago

fixes https://github.com/wfxr/forgit/issues/256 fixes https://github.com/wfxr/forgit/issues/257

Check list

[x] I have performed a self-review of my code
[x] I have commented my code in hard-to-understand areas
[x] I have made corresponding changes to the documentation

Description

Type of change

[x] Bug fix
[ ] New feature
[ ] Refactor
[ ] Breaking change
[ ] Documentation change

Test environment

Shell
- [x] bash
- [x] zsh
- [ ] fish
OS
- [x] Linux
- [ ] Mac OS X
- [ ] Windows
- [ ] Others:

Fixes:

gbtec-markusmeier commented 1 year ago

@gbtec-markusmeier Thanks a lot for your bug reports and this fix. Do I understand it correctly that this solution only fixes the situation for bash? Do we need a different behavior for zsh?

Zsh works fine, we don't have that problem there: zsh reports only variables when calling set.

Solution is tested in both zsh and bash, but not in fish (which I don't have at hand).