Closed sandr01d closed 1 year ago
@sandr01d Thanks for your PR. For me this is basically fine.
I wonder, however, if we could implement a more general solution for passing custom arguments to git commands, which would also cover #281 for example.
@cjappl @wfxr What do you say?
@sandr01d Thanks for your PR. For me this is basically fine.
I wonder, however, if we could implement a more general solution for passing custom arguments to git commands, which would also cover #281 for example.
@cjappl @wfxr What do you say?
I think that's ok, but I'd say let's merge this one now and think of that solution separately unless you already have a good one in mind.
Just to not let it get in the way of a nice improvement! when we have that, we can easily swap this out. I'm good with this going in as-is
@sandr01d Thanks for your PR. For me this is basically fine.
I wonder, however, if we could implement a more general solution for passing custom arguments to git commands, which would also cover #281 for example.
@cjappl @wfxr What do you say?
I think a more general solution would be great, ideally one where the code can be shared across the different functions. I'm open to help implement such a solution, but it is currently hard for me to find the time. Also there should probably be a discussion about what exactly we'd want to have. So I agree with @cjappl's suggestion to merge this PR now and swap it out later.
@sandr01d I have filed PR #292 with a more general solution which should cover your use case. Could you check if setting the following variable does what you want using this branch?
export FORGIT_BLAME_GIT_OPTS="--date=iso8601"
Closing in favor of #292
Check list
Description
Allow the user to set a custom date format for
gbl
inFORGIT_BLAME_DATE
for the preview. The current value (short) stays the default, so the preview does not get cluttered. This is especially useful with delta, which currently fails to apply it's blame theme when date is set to anything other than iso8601 or iso8601-local, see https://github.com/wfxr/forgit/issues/268#issuecomment-1377916562Type of change
Test environment