Process files in a single command in ga & gcf

sandr01d commented 1 year ago

Check list

[X] I have performed a self-review of my code
[ ] I have commented my code in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

Description

Checkout/Add files in a single command in _forgit_add and _forgit_checkout_file() instead of processing each file individually with xargs. This has the following benefits:

It's faster
Prevents git from spamming "Updated 1 path from the index" for each file when checking out files

Type of change

[ ] Bug fix
[ ] New feature
[X] Refactor
[ ] Breaking change
[ ] Documentation change

Test environment

Shell
- [X] bash
- [X] zsh
- [X] fish
OS
- [X] Linux
- [ ] Mac OS X
- [ ] Windows
- [ ] Others:

cjappl commented 1 year ago

Cool! Passes the eye test, but let me test it out at work next week before merging!

sandr01d commented 1 year ago

Sure, I'll do the same.

On January 14, 2023 2:18:48 PM UTC, Chris Apple @.***> wrote:

Cool! Passes the eye test, but let me test it out at work next week before merging!

-- Reply to this email directly or view it on GitHub: https://github.com/wfxr/forgit/pull/279#issuecomment-1382751794 You are receiving this because you authored the thread.

Message ID: @.***>

cjappl commented 1 year ago

Cool! functionally works for me. I pinged @carlfriedrich for a second pair of eyes, but I'll merge this soon either way unless I hear objections

sandr01d commented 1 year ago

Tested this throughout the day. Everything is working as supposed to for me.

cjappl commented 1 year ago

Working well for me, shippin it

wfxr / forgit