Detect unexported variables in fish correctly (Fix #289)

wfxr / forgit

:zzz: A utility tool powered by fzf for using git interactively.

MIT License

4.32k stars 136 forks source link

Detect unexported variables in fish correctly (Fix #289) #290

Closed IndianBoy42 closed 1 year ago

IndianBoy42 commented 1 year ago

Check list

[x] I have performed a self-review of my code
[x] I have commented my code in hard-to-understand areas
[x] I have made corresponding changes to the documentation

Description

See #289 for the complete details

Type of change

[x] Bug fix
[ ] New feature
[ ] Refactor
[ ] Breaking change
[ ] Documentation change

Test environment

Shell
- [ ] bash
- [ ] zsh
- [x] fish
OS
- [x] Linux
- [ ] Mac OS X
- [ ] Windows
- [ ] Others:

cjappl commented 1 year ago

Seems totally reasonable to me. Thanks for catching. Requested review from @carlfriedrich as well to make sure that tracks with his understanding.

I'll merge and close later in the week regardless. Thanks for the contribution

IndianBoy42 commented 1 year ago

So we actually need the space. We could, however, extend the expression to also match the variable name followed by the end of the line ($), which I assume is what you have in your case? Could you check that?

Oh, that makes sense, it makes me think \b for word boundary potentially matches the intent most closely

cjappl commented 1 year ago

Thanks for the submission @IndianBoy42