Fix broken cherry picking

[carlfriedrich]

Check list

• [x] I have performed a self-review of my code
• [x] I have commented my code in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation

Description

With the changes of #261 and #266 we accidentally broke the return value of _forgit_cherry_pick, which led to the loop in _forgit_cherry_pick_from_branch being terminated in the wrong cases. Fix this by moving all the post processing after fzf to a later call.

Also simplify the array population using a single line instead of a loop.

This should also fix #286 ("fatal: bad revision ''").

Type of change

• [x] Bug fix
• [ ] New feature
• [ ] Refactor
• [ ] Breaking change
• [ ] Documentation change

Test environment

• Shell
  • [x] bash
  • [ ] zsh
  • [ ] fish
• OS
  • [x] Linux
  • [ ] Mac OS X
  • [ ] Windows
  • [ ] Others:

[sandr01d]

Hey @carlfriedrich, thanks for moving this forward. I wasn't sure how to progress with #286 since I couldn't reproduce the outstanding issue. This works fine in my environment.