wfxr / forgit

:zzz: A utility tool powered by fzf for using git interactively.
MIT License
4.32k stars 136 forks source link

Fix git options #296

Closed carlfriedrich closed 1 year ago

carlfriedrich commented 1 year ago

Adding options to a command in a quoted variable as introduced in #292 causes problems in several cases unfortunately (e.g. git rebase interpreting an empty string argument as a remote, which leads to an error "unknown upstream ''").

Change the implementation in a way that each git command is stored in a shell variable, including the options, which is then evaluated.

Check list

Description

Type of change

Test environment

cjappl commented 1 year ago

Works for me :) good job catching it.

carlfriedrich commented 1 year ago

@cjappl Thanks for the quick check!

Gonna merge this directly as it is a fix for a bug introduced in #292. Hopefully everything works as it should. If you encounter any unintended behavior, please open an issue for it and assign me directly.