Restore support for appending FORGIT_INSTALL_DIR to path

[tapayne88]

Check list

• [x] I have performed a self-review of my code
• [ ] I have commented my code in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation

Description

It seems somewhere along the line FORGIT_INSTALL_DIR stopped getting exported. According to the README you can append it to your path to get access to git forgit ... commands however this seems to no longer work - this is an attempt to restore this functionality.

https://github.com/wfxr/forgit/blob/5642a1a7307c17d452271b9e7aaa8bcec6a47f53/README.md?plain=1#L174

Type of change

• [x] Bug fix
• [ ] New feature
• [ ] Refactor
• [ ] Breaking change
• [ ] Documentation change

Test environment

• Shell
  • [ ] bash
  • [x] zsh
  • [ ] fish
• OS
  • [x] Linux
  • [ ] Mac OS X
  • [ ] Windows
  • [ ] Others:

[tapayne88]

Can you do a spot check and see if the same issue exists in fish?

Yeah, spun up a quick fish + fisher shell and it does seem to suffer the same issue. With something like the README snippet I get /bin appended to my $PATH instead of the expected path.

Something like the following added to conf.d/forgit.plugin.fish seems to fix it

set -x FORGIT_INSTALL_DIR "$INSTALL_DIR/conf.d"

I also seem to have trouble running the builtin aliases in fish without patching the following line to export the FORGIT var (adding -x) https://github.com/wfxr/forgit/blob/5642a1a7307c17d452271b9e7aaa8bcec6a47f53/conf.d/forgit.plugin.fish#L4

[cjappl]

Good finds. Will you add those to this PR to fix it all in one swoop?

I’ll approve and merge after that.

On Sun, May 14, 2023 at 3:03 PM, Tom @.***(mailto:On Sun, May 14, 2023 at 3:03 PM, Tom < wrote:

Can you do a spot check and see if the same issue exists in fish?

Yeah, spun up a quick fish + fisher shell and it does seem to suffer the same issue. With something like the README snippet I get /bin appended to my $PATH instead of the expected path.

Something like the following added to conf.d/forgit.plugin.fish seems to fix it

set

-x

FORGIT_INSTALL_DIR

"

$INSTALL_DIR

/conf.d

"

I also seem to have trouble running the builtin aliases in fish without patching the following line to export the FORGIT var (adding -x) https://github.com/wfxr/forgit/blob/5642a1a7307c17d452271b9e7aaa8bcec6a47f53/conf.d/forgit.plugin.fish#L4

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because your review was requested.Message ID: @.***>

[tapayne88]

Good finds. Will you add those to this PR to fix it all in one swoop?

That should be done @cjappl 👍

[cjappl]

Thanks for the contribution!