search

wfxr / forgit

:zzz: A utility tool powered by fzf for using git interactively.
MIT License
4.32k stars 136 forks source link

Add new workflow to update homebrew formula on release #341

Closed cjappl closed 5 months ago

cjappl commented 5 months ago

This workflow was found here:

https://github.com/dawidd6/action-homebrew-bump-formula

This should be very similar to our AUR workflow, which can be seen here: https://github.com/wfxr/forgit/blob/ab7400ddb37c758b8247ce0884cd2283a873e258/.github/workflows/aur.yaml#L1-L20

I am writing an email to @wfxr asking him to add a BREW_TOKEN to our secrets with the appropriate permissions so this can run :). This change should not be submitted until he has confirmed the BREW_TOKEN has been added to our secrets.

carlfriedrich commented 5 months ago

@cjappl Thanks for the quick fixes. Just being curious: did you generate a personal access token in your account for this purpose, so that the automatic brew commits will be done in your name?

cjappl commented 5 months ago

@cjappl Thanks for the quick fixes. Just being curious: did you generate a personal access token in your account for this purpose, so that the automatic brew commits will be done in your name?

No, I could, but it's probably safer from a security side to have wfxr do it (just so I don't have to send one of my tokens in plaintext to him via email or similar). He is still the one that must update any secrets or other Settings of this project, as it's under his name.

I would expect the commits likely end up under his user account in that case!

cjappl commented 5 months ago

Thanks @wfxr ! Will merge sometime tomorrow.

carlfriedrich commented 5 months ago

@cjappl Did you merge into FixZshCompletions on purpose?

cjappl commented 5 months ago

Whoa. No I did not. Thank you for catching..... Let me fix that

cjappl commented 5 months ago

Great catch @carlfriedrich . would you please review #342 and #340 to make sure they are both as you expect them to be?