fix: avoid polluting global namespace - Githubissues

wfxr / forgit

:zzz: A utility tool powered by fzf for using git interactively.

MIT License

4.32k stars 136 forks source link

fix: avoid polluting global namespace #347

Closed wfxr closed 4 months ago

wfxr commented 4 months ago

Check list

[ ] I have performed a self-review of my code
[ ] I have commented my code in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

Description

Minor fix to avoid variables used locally in forgit.plugin.zsh to be exported in to the global namespace.

Type of change

[ ] Bug fix
[ ] New feature
[ ] Refactor
[ ] Breaking change
[ ] Documentation change

Test environment

Shell
- [ ] bash
- [ ] zsh
- [ ] fish
OS
- [ ] Linux
- [ ] Mac OS X
- [ ] Windows
- [ ] Others:

cjappl commented 4 months ago

LGTM if someone else wants to review too 👍

carlfriedrich commented 4 months ago

Works for me!