fix(fish): clean up variables - Githubissues

wfxr / forgit

:zzz: A utility tool powered by fzf for using git interactively.

MIT License

4.32k stars 136 forks source link

fix(fish): clean up variables #350

Closed folliehiyuki closed 4 months ago

folliehiyuki commented 4 months ago

Check list

[x] I have performed a self-review of my code
[ ] I have commented my code in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

Description

use status dirname builtin to save 1 dirname call
use builtin test function instead of [ syntax
use local scoping for INSTALL_DIR variable (and make it lowercase to indicate such change)

Ref: https://fishshell.com/docs/current/cmds/test.html

Type of change

[ ] Bug fix
[ ] New feature
[x] Refactor
[ ] Breaking change
[ ] Documentation change

Test environment

Shell
- [ ] bash
- [ ] zsh
- [x] fish
OS
- [x] Linux
- [ ] Mac OS X
- [ ] Windows
- [ ] Others: