Refactor: Replace _forgit_extract_sha variable with function - Githubissues

wfxr / forgit

:zzz: A utility tool powered by fzf for using git interactively.

MIT License

4.32k stars 136 forks source link

Refactor: Replace _forgit_extract_sha variable with function #366

Closed sandr01d closed 3 months ago

sandr01d commented 3 months ago

Check list

[X] I have performed a self-review of my code
[ ] I have commented my code in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

Description

We used to store code that extracts the commit hash from a line in a variable. This commit replaces this variable with a function.

Note

This PR belongs to #326 and resulted from discussions in #324.

Type of change

[ ] Bug fix
[ ] New feature
[X] Refactor
[ ] Breaking change
[ ] Documentation change

Test environment

Shell
- [ ] bash
- [X] zsh
- [ ] fish
OS
- [X] Linux
- [ ] Mac OS X
- [ ] Windows
- [ ] Others:

sandr01d commented 3 months ago

Changes have been merged with #326