Refactor: Do not ignore shellcheck 2207

[sandr01d]

Check list

• [X] I have performed a self-review of my code
• [ ] I have commented my code in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation

Description

We sometimes capture multiline output in an array. We used to do so directly, while setting IFS to "\n" to control splitting. This has the downside that bashs glob expansion will be invoked. I think the original reason we did use this technique was that it does work in both zsh and bash. Since we always execute bin/git-forgit in bash now, this is not necessary anymore. We can use read -r in such cases to add each line to the array without glob expansion. This is the idiomatic way to do so and recommended in shellcheck 2207. In my personal opinion this is also a cleaner and more straightforward approach than setting and resetting $IFS.

Type of change

• [ ] Bug fix
• [ ] New feature
• [X] Refactor
• [ ] Breaking change
• [ ] Documentation change

Test environment

• Shell
  • [X] bash
  • [X] zsh
  • [ ] fish
• OS
  • [X] Linux
  • [ ] Mac OS X
  • [ ] Windows
  • [ ] Others:

[cjappl]

Do we need to tweak our github action that runs shellcheck to enforce this now? Better than backsliding later on

[wfxr]

Do we need to tweak our github action that runs shellcheck to enforce this now? Better than backsliding later on

I think we'd better to keep some flexibility since many checks themselves have exceptions, like SC1091, SC2145, SC2206, etc. IMO we don't have to stick to all checks as long as we have a good reason.