wfxr / forgit

:zzz: A utility tool powered by fzf for using git interactively.
MIT License
4.32k stars 136 forks source link

Do not disable shellcheck 2206 and 2068 in _forgit_ignore #382

Closed sandr01d closed 2 months ago

sandr01d commented 2 months ago

Check list

Description

Shellcheck 2206 and 2068 have been disabled in _forgit_ignore for a very long time. The code that triggers the shellchecks was added in ce240ac before the shelllcheck action had been added. The shellceck for the lines in question got disabled in c14ce93. The commit message does not state why, but I'm guessing that this has been done simply to make the CI pass. I do not think disabling the shellchecks is necessary here. I've implemented the fixes shellcheck suggest and I could not find any issues with it.

Type of change

Test environment

carlfriedrich commented 2 months ago

LGTM