wfxr / forgit

:zzz: A utility tool powered by fzf for using git interactively.
MIT License
4.44k stars 140 forks source link

_forgit_ignore_clean is unused #407

Open sandr01d opened 2 weeks ago

sandr01d commented 2 weeks ago

Check list

Environment info

Problem / Steps to reproduce

The forgit_ignore_clean() function is currently unused. It is also not possible to invoke the function by executing forgit::ignore::clean because ignore_clean is not in public_commands. I'm not fully sure what the intended behavior is here. Should ignore_clean get added to public_commands or was it intended as a private function and should be dropped? Let me know and I'll send a PR.

carlfriedrich commented 1 week ago

@sandr01d Good find, never noticed this. Blaming this function shows that it has been there under different names before we moved the implementation to git-forgit and even in the very first commit. Seems like it has never been called anywhere, though.

@wfxr Can you tell us more perhaps?