wfxr / tmux-fzf-url

🚀 Quickly open urls on your terminal screen!
Other
529 stars 42 forks source link

Latest version doesn't seem to work? #12

Closed h0adp0re closed 3 years ago

h0adp0re commented 3 years ago

I can't get it to work, is the load order of plugins somehow significant?

I have fzf installed via Homebrew and in my $PATH, I can use it and do use it in other scripts.

wfxr commented 3 years ago

Can't repro. Are you sure the plugin has been sourced by tmux correctly?

h0adp0re commented 3 years ago

yeah, I mean it's just this, right? is the order important? are there plugins that conflict with this one?

set -g @plugin 'tmux-plugins/tpm'
set -g @plugin 'tmux-plugins/tmux-resurrect'
set -g @plugin 'tmux-plugins/tmux-continuum'
set -g @plugin 'tmux-plugins/tmux-prefix-highlight'
set -g @plugin 'tmux-plugins/tmux-open'
# set -g @plugin 'tmux-plugins/tmux-urlview'
set -g @plugin 'tmux-plugins/tmux-battery'
set -g @plugin 'aaronlna/tmux-plugin-sysstat'
set -g @plugin 'narugit/tmux-temp-mac'
set -g @plugin 'wfxr/tmux-fzf-url'
wfxr commented 3 years ago

Weird. You can try the following steps to debug:

  1. cd ~/.tmux/plugins/tmux-fzf-url (where the plugins located in, modify the path if you used a different location)
  2. echo https://google.com (to print a url for testing)
  3. ./fzf-url.sh (call the script directly)

If it works I guess you or some other plugin maybe overwrite the keybind.

h0adp0re commented 3 years ago

this is what happened:

./fzf-url.sh: line 24: mapfile: command not found
./fzf-url.sh: line 25: mapfile: command not found
./fzf-url.sh: line 26: mapfile: command not found
./fzf-url.sh: line 27: mapfile: command not found
h0adp0re commented 3 years ago

brew install bash fixed it, thanks for the plugin, it's very handy

d1egoaz commented 2 years ago

would be great to add this to the readme, MacOS uses a very old bash version

wfxr commented 2 years ago

Hi @d1egoaz It's already been documented: https://github.com/wfxr/tmux-fzf-url#-installation