search

wg-perception / object_recognition_core

The core of object recognition, where the development now happens
48 stars 47 forks source link

Fix detection: error: unrecognized arguments: #23

Closed awesomebytes closed 10 years ago

awesomebytes commented 10 years ago

As of referenced in this issue: https://github.com/wg-perception/object_recognition_core/issues/20 When launching the detection (and maybe training too) we get the error:

usage: detection [-h] [-c CONFIG_FILE] [--visualize] [--niter ITERATIONS]
                 [--shell] [--gui] [--logfile LOGFILE] [--graphviz]
                 [--dotfile DOTFILE] [--stats]
detection: error: unrecognized arguments: __name:=clusters_detection __log:=/home/sampfeiffer/.ros/logs/94f5f7a0-b989-11e3-aa66-e0cb4e1f7c63/clusters_detection-4.log
[clusters_detection-4] process has died [pid 18346, exit code 2, cmd /home/sampfeiffer/public_workspaces/ork_ws/src/ork_core/apps/detection -c /home/sampfeiffer/public_workspaces/reem_manipulation_ws/src/reem_object_recognition/config/tabletop/detection.clusters.ros.ork.reem.throtled __name:=clusters_detection __log:=/home/sampfeiffer/.ros/logs/94f5f7a0-b989-11e3-aa66-e0cb4e1f7c63/clusters_detection-4.log].
log file: /home/sampfeiffer/.ros/logs/94f5f7a0-b989-11e3-aa66-e0cb4e1f7c63/clusters_detection-4*.log

This is because the arguments name:= and log:= are generated by the launchfile. So with this patch I'm filtering them out.

vrabaud commented 10 years ago

I think we agreed that this has been done on the tabletop side right ? (as the core has to remain ROS agnostic).

awesomebytes commented 10 years ago

But, if I want to launch TOD, I'll have the same problem. And probably with any other recognizer if we get them to work again. You proposed using a ROS function that gets rid of the ROS parameters, which looked very well, but then you really need to have ROS installed, so that's bad.

This patch is kind of "ROS-related" but does not hurt anyone executing it without ROS. It's just getting rid of specific parameters generated by ROS. Give it a second thought please.

vrabaud commented 10 years ago

sorry, for the delay, that totally makes sense and keeps the spirit of keeping the core ROS agnostic. Thx.