Added try/catch in rviz plugin to prevent crash

wg-perception / object_recognition_ros

ROS components usable byt the object_recognition pipeline

16 stars 31 forks source link

Added try/catch in rviz plugin to prevent crash #16

Closed hersh closed 10 years ago

hersh commented 10 years ago

When the rviz plugin received my RecognizedObjects message, it crashed rviz.

I traced the exception back as far as info_cache.cpp:62 where it initializes an object_recognition_core::db::ObjectDbParameters object.

The message I was sending was probably not what it was expecting, but that should still not crash rviz. So I just added the try/catch you see here, and that makes it work fine for my purposes.

awesomebytes commented 10 years ago

I confirm this has happened to me before in the past (and it's quite annoying). The patch is quite simple and I believe you tested it so I'm just gonna merge.

vrabaud commented 10 years ago

thx, on a break. Will release that asap. If you have better suggestions for object_recognition_msgs, please, let's write a REP or make it go upstream.

vrabaud commented 10 years ago

done, thx !