wg-perception / people

274 stars 200 forks source link

[face_detector] Add RGB sample with PR2 #31

Open 130s opened 9 years ago

130s commented 9 years ago

Add a face detection sample launch using RGBD topics with PR2.

DLu commented 9 years ago

It doesn't fit in the teleop package, but I'm not sure whether it really fits here either. What do you think @dlaz ?

dlaz commented 9 years ago

I agree with @130s's initial PR that this belongs somewhere in the PR2 repos, though I don't see an existing package that looks like a good fit. Another option which could be compelling is to add a people_simulation package which has this launch file, and whatever launch file was used to launch gazebo in the top screenshot. My only concern with that is that I'd rather not add gazebo as a dependency to people.

@dlu, a launch file for running the leg detector in simulation would be awesome too.

130s commented 9 years ago

Ok, I created people_app package; the launch files I'm willing to add aren't simulation specific, so I think app or sample might be more appropriate. How does this sound? I'll add tests too.