wg-perception / people

269 stars 197 forks source link

Noetic test dev #86

Closed Axelito95 closed 3 years ago

Axelito95 commented 3 years ago

This is a fix to import leg_detector in noetic version. opencv -> opencv2

DLu commented 3 years ago

Thanks for working on this.

Right now the CI isn't working because bfl is still in the package.xml .

Axelito95 commented 3 years ago

Thanks for working on this.

Right now the CI isn't working because bfl is still in the package.xml .

i don't know what is CI, i saw that in your package you already added bfl migration key bfl . i had bfl library problem but i fixed this on my pc installed the library manually : sudo apt install liborocos-bfl-dev

up : i saw that you right in package.xml is bfl depedency o.o, i will fix this soon

DLu commented 3 years ago

My apologies, CI stands for continuous integration which is the system which ensures the code will compile for everyone.

Axelito95 commented 3 years ago

My apologies, CI stands for continuous integration which is the system which ensures the code will compile for everyone.

Np ! just my bad that i don't know CI acronyme.Added new bfl key dependency

i see that the build doesn't pass because : Checking for module 'orocos-bfl' -- No package 'orocos-bfl' found

On my pc i fixed it with : sudo apt-get install -y liborocos-bfl-dev

DLu commented 3 years ago

Thank you very much @Axelito95 for figuring this out!

Axelito95 commented 3 years ago

Thank you very much @Axelito95 for figuring this out!

You are welcome ! And thank you too for your working ! Happy new year ;) !