wg-perception / people

274 stars 200 forks source link

[Noetic] Add missing dependency on yaml-cpp #98

Closed sloretz closed 3 years ago

sloretz commented 3 years ago

Maybe this will fix https://build.ros.org/job/Nbin_uF64__face_detector__ubuntu_focal_amd64__binary/9 . I have not built locally to confirm.

That job has been failing with

23:05:39 /tmp/binarydeb/ros-noetic-face-detector-1.4.0/src/face_detection.cpp:79:10: fatal error: yaml-cpp/yaml.h: No such file or directory
23:05:41    79 | #include <yaml-cpp/yaml.h>
23:05:41       |          ^~~~~~~~~~~~~~~~~

Which now seems to be causing a regression of people in Noetic: http://repositories.ros.org/status_page/ros_noetic_default.html?q=REGRESSION

yaml-cpp seems to be the right rosdep key. face_detector is already using the yaml-cpp target, but it must have been expecting to get it transitively.

$ find /usr/include -name yaml.h
/usr/include/yaml-cpp/yaml.h
/usr/include/yaml.h
$ dpkg -S /usr/include/yaml-cpp/yaml.h
libyaml-cpp-dev: /usr/include/yaml-cpp/yaml.h

https://index.ros.org/d/yaml-cpp/

k-okada commented 3 years ago

Please merge this patch to fix https://build.ros.org/view/Nbin_uF64/job/Nbin_uF64__face_detector__ubuntu_focal_amd64__binary/207/console

k-okada commented 3 years ago

@dlu thank you for merging! Could you also release 1.4.1/noetic ? Thanks in advance.

DLu commented 3 years ago

https://github.com/ros/rosdistro/pull/30946