wg-perception / tabletop

conversion of the old tabletop stack to ecto
7 stars 24 forks source link

TabletopTableDetector pipeline parameters ignored #23

Open corot opened 9 years ago

corot commented 9 years ago

I noticed that if you remove the tabletop_detector/clusterer dictionary level, it works. E.g.

pipeline1:
  type: TabletopTableDetector
  module: 'object_recognition_tabletop'
  inputs: [source1]
  outputs: [sink1]
  parameters:
    # table detector
    min_table_size: 5000
    plane_threshold: 0.01
    table_cluster_tolerance: 0.01
    vertical_frame_id: '/map'
    # clusterer
    z_crop: 0.25  # The amount to keep in the z direction relative to the coordinate frame defined by the pose (def. 0.5)
    z_min:  0.002 # The amount to crop above the plane, in meters (def. 0.0075)
    cluster_distance: 0.01  # The maximum distance between a point and the cluster it belongs to (def. 0.02)
    min_cluster_size: 300   # Min number of points for a cluster (def. 300)
corot commented 9 years ago

I have just noticed that the detection documentation is updated, so only tabletop tutorial and examples must be updated

dornhege commented 9 years ago

For the TabletopObjectDetector at least the threshold parameter is not connected to the parameter in the code. I haven't checked the other, but suspect the same.

corot commented 8 years ago

I think the only really used is 'tabletop_object_ids'