migrated to netty 4.0.4

jongwook commented 11 years ago

As netty 4 API has been fixed now, I made lettuce working with netty 4.0.4.Final.

This passes all 219 tests with no complaints, in Mac OS X 10.8.4 / Java 1.7.0_11.

Aside from find-and-replace changes, there are a few changes like

ChannelInitializer instead of ChannelPipelineFactory and simplified ConnectionWatchdog.run()
@ChannelHandler.Sharable annotation to each ChannelHandler classes, to make the multiplicity checker happy during reconnection
Manually releasing ByteBuf, as netty 4 requires it, as well as manual HashedWheelTimer stopping
Command.output != null checks to safely ignore responses from timed out commands. This makes the ClientTask.timeout() the happy

Please review the changes and I'd be happy to have it merged to your repository, or possibly in a separate branch for netty 4.

Many thanks for making this awesome library!

wg commented 11 years ago

Thanks for the pull request @jongwook! I have already done some preliminary netty 4 migration work on a private branch and won't be merging this request, but will use it as a reference. Thank you!

ninowalker commented 9 years ago

It seems this is still pending. Is there a netty 4.0.x version still in the works?

kichik commented 9 years ago

@ninowalker you can use the following fork for Netty 4 support. It is still under active development and accepts pull requests. https://github.com/mp911de/lettuce/

wg / lettuce

migrated to netty 4.0.4 #21