search

wg / scrypt

Java implementation of scrypt
Apache License 2.0
426 stars 144 forks source link

License Information Not Included in Jar #6

Open codebynight opened 11 years ago

codebynight commented 11 years ago

Hi Will, I've been wondering how to handle the license information. Can you include it with Maven? For example: http://jeffbadge.blogspot.com/2010/07/telling-maven-to-include-license-info.html.

Thanks!

wg commented 11 years ago

Hi, thanks for the suggestion! Including the license in the jar file does seem like a good idea, and I've neglected to put a NOTICE file which is needed for Colin's BSD-licensed scrypt code.

I'll take a look at how some other Java projects handle this and see what's generally accepted. The jar does currently include the .pom file which has a license section.

codebynight commented 11 years ago

Will, Thank you very much for writting the pure java version. I intend to use it for a custom application which uses the spring framework. I'm not a career programmmer, but i love programming. :)

I wrote a class to handle password encoding using this interface http://static.springsource.org/spring-security/site/docs/3.1.x/apidocs/org/springframework/security/crypto/password/PasswordEncoder.html .

And your scryptutil class and it works nicely!

The goal is to evetually use it as an Authenticationprovider: http://static.springsource.org/spring-security/site/docs/3.0.x/apidocs/org/springframework/security/authentication/AuthenticationProvider.html

You could code these things and increase acceptance in the spring community. ;) I can send you what i wrote so far if you like. Its not very difficult to create the password encoder class. About 10 minutes.

Thank you very much, jose.

On Thursday, November 1, 2012, Will Glozer wrote:

Hi, thanks for the suggestion! Including the license in the jar file does seem like a good idea, and I've neglected to put a NOTICE file which is needed for Colin's BSD-licensed scrypt code.

I'll take a look at how some other Java projects handle this and see what's generally accepted. The jar does currently include the .pom file which has a license section.

— Reply to this email directly or view it on GitHubhttps://github.com/wg/scrypt/issues/6#issuecomment-10000684.

Sent from Gmail Mobile