search

wgOpenSource / gqlclans

MIT License
1 stars 0 forks source link

#16 Configuration for grahpql service #27

Open erm0l0v opened 6 years ago

erm0l0v commented 6 years ago

Added file settings.py and command init_settings.py for generate settings_local.py

Docker use env values to override settings.

Should we also add local (ignored in git) configuration for docker_compose.test.yml in order to remove WGAPI_APPLICATION_ID from repo? What do you think?

frsv commented 6 years ago

afaik, docker_compose.test.yml is using by docker cloud to run tests, so we can't add it to .gitignore

erm0l0v commented 6 years ago

afaik, docker_compose.test.yml is using by docker cloud to run tests, so we can't add it to .gitignore

No I mean use extra compose file to override docker_compose.test.yml - https://docs.docker.com/compose/reference/overview/#use--f-to-specify-name-and-path-of-one-or-more-compose-files

However file docker_compose.test.override.yml don't override settings automaticaly( Need use 2 params -f or setup env variable before run tests in docker on local machine.

frsv commented 6 years ago

So we need WGAPI id only for our snapshot tests? I'd better refuse to use request snapshots for testing, as I've already done in #25

erm0l0v commented 6 years ago

We need to set up environment variable WGAPI_APPLICATION_ID on sloppy before merge this PR.