wgaylord / AutoCrafters

Bug tracker for AutoCrafters
2 stars 1 forks source link

ingredients in "input" chest are used regardless of wether "output" chest is full or not. #4

Closed Sidious82 closed 7 years ago

Sidious82 commented 7 years ago

The problem? : autocrafter can potentially waste valueable recipe ingredients by crafting into a full chest

What you expect to happen: some sort of "safety" stop where the autocrafter simply stops working if the output chest is full

What actually happened: ingredients in "input" chest are used regardless of current state of "output" chest.

Steps to reproduce. build autocrafter, place recipe and work as normally intended. once output chest is full, continue to send a redstone signal to the autcrafter: it will pull ingredients but produce no product.

**thank you for all your hard work. this plugin is great! my whole community loves it.

wgaylord commented 7 years ago

I will try to reproduce this. But this is one of the things I tested for.

On Mar 27, 2017 8:31 PM, "Sidious EightyTwo" notifications@github.com wrote:

The problem? : autocrafter can potentially waste valueable recipe ingredients by crafting into a full chest

What you expect to happen: some sort of "safety" stop where the autocrafter simply stops working if the output chest is full

What actually happened: ingredients in "input" chest are used regardless of current state of "output" chest.

Steps to reproduce. build autocrafter, place recipe and work as normally intended. once output chest is full, continue to send a redstone signal to the autcrafter: it will pull ingredients but produce no product.

**thank you for all your hard work. this plugin is great! my whole community loves it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chibill/AutoCrafters/issues/4, or mute the thread https://github.com/notifications/unsubscribe-auth/ACCNyQt0Kb3Hc9zhwENx3yAMUhkrW5CXks5rqGMGgaJpZM4MrB1Z .

Sidious82 commented 7 years ago

if i was not clear enough i am happy to communicate further. i can reproduce this 100% of the time i try

wgaylord commented 7 years ago

I can't reproduce this at all. What version of Autocrafters are you using? Also this basic check has been in the code from 1.0.0. And I just double checked it now.

Steps that you did to get it to happen?