wger-project / docker

Production...ish docker-compose image for wger
GNU Affero General Public License v3.0
125 stars 43 forks source link

development environments #93

Closed Dieterbe closed 2 months ago

rolandgeider commented 2 months ago

careful with moving the prod compose to its own sub folder, the names of the docker volumes are prefixed with so moving this would seeminly reset all installations, I would just leave that compose file in root.

Also like we talked on discord, we should do something about the config file(s), but that can be done later.

Dieterbe commented 2 months ago

careful with moving the prod compose to its own sub folder, the names of the docker volumes are prefixed with so moving this would seeminly reset all installations, I would just leave that compose file in root.

This shouldn't cause an issue, precisely because as you say, volumes and containers are given names (and stored in a path) that are independent of where you run them from. That said it's worth trying to confirm. I'm not on my pc but I can try later. The postgres-data would be a good one to try it with right ?

Dieterbe commented 2 months ago

Ah your syntax got swallowed a bit but now I see what you mean. According to https://docs.docker.com/compose/environment-variables/envvars/#compose_project_name we can set a custom name, so we can set one that matches the previous directory name, although I suppose people could have checked out this repo in a dir with any name of their choosing, so therefore your suggestion to put back in the root is probably best 🤔

rolandgeider commented 2 months ago

yes exactly, we don't know where people checked this out (plus it makes that the "main" compose file)