search

wgnet / webium

Webium is a Page Object pattern implementation library for Python (http://martinfowler.com/bliki/PageObject.html). It allows you to extend WebElement class to your custom controls like Link, Button and group them as pages.
Apache License 2.0
161 stars 37 forks source link

Find a driver instance under WebElement object #15

Closed kejkz closed 7 years ago

kejkz commented 7 years ago

This PR adds the ability to fetch the driver instance directly from the WebElement object and do not try to initialize the new driver instance if _driver attribute does not exist. This is needed if custom driver instance is used while initializing the Webium page objects.

SUNx2YCH commented 7 years ago

@kejkz, thanks for contribution! Looks fine for me. Will look into Travis issues on weekend, it seems that selenium v3 ruined the build.

kejkz commented 7 years ago

@SUNx2YCH I've actually just pushed the proposed change, with the custom installation of the geckodriver and latest Firefox (50), I hope it will work.

Thank you for the fine library

SUNx2YCH commented 7 years ago

@kejkz, sorry, but I'd prefer not to use GeckoDriver on Travis until it become more stable. Could you please remove the 2nd commit and rebase on master? See #16.

kejkz commented 7 years ago

@SUNx2YCH sure, np

kejkz commented 7 years ago

@SUNx2YCH Done! Thanks again for the effort.

SUNx2YCH commented 7 years ago

@kejkz, this change is now a part of 1.2.0 release:

Thanks again for contribution.