wgnf / liz

liz (ˈlΙͺz) is a tool to extract license-information from your project/solution aimed on a fast and correct process. Whether it's via a dotnet-CLI-Tool, Cake-Addin or Nuke-Addon
MIT License
10 stars 0 forks source link

fix: fix missing packages when sdk-style-project has project-reference to non-sdk-style-project #124

Closed wgnf closed 2 years ago

wgnf commented 2 years ago

πŸ“« Addressed Issue(s)

πŸ“„ Description

This bug was observed a long time ago. When an SDK-Style-Project has a project-reference to a Non-SDK-Style project, and one starts analysing the SDK-Style-Project with IncludeTransitiveDependencies turned on, the package-references in the Non-SDK-Style project are not included.

βœ… Checks

codecov[bot] commented 2 years ago

Codecov Report

Merging #124 (8f0590a) into main (6670bfe) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   96.78%   96.83%   +0.04%     
==========================================
  Files          54       54              
  Lines        2305     2335      +30     
==========================================
+ Hits         2231     2261      +30     
  Misses         74       74              
Impacted Files Coverage Ξ”
src/Core/Liz.Core/Projects/GetProjectReferences.cs 100.00% <100.00%> (ΓΈ)
.../Core/Liz.Core/Projects/GetProjectsViaSlnParser.cs 97.93% <100.00%> (+0.87%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.