Closed wgnf closed 2 years ago
Merging #65 (b11d71c) into main (9f1c981) will increase coverage by
0.57%
. The diff coverage is98.78%
.
@@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 94.92% 95.50% +0.57%
==========================================
Files 26 38 +12
Lines 1183 1400 +217
==========================================
+ Hits 1123 1337 +214
- Misses 60 63 +3
Impacted Files | Coverage Δ | |
---|---|---|
...ation/LicenseUrlElementLicenseInformationSource.cs | 93.15% <ø> (ø) |
|
src/Tool/Liz.Tool/CommandLine/CommandProvider.cs | 81.17% <90.47%> (-2.16%) |
:arrow_down: |
src/Tool/Liz.Tool/CommandLine/CommandRunner.cs | 98.48% <97.43%> (-1.52%) |
:arrow_down: |
...ormation/LicenseElementLicenseInformationSource.cs | 91.66% <100.00%> (ø) |
|
...ion/LicenseTypeFromTextLicenseInformationSource.cs | 100.00% <100.00%> (ø) |
|
...LicenseType/ApacheLicenseTypeDefinitionProvider.cs | 100.00% <100.00%> (ø) |
|
...es/LicenseType/BsdLicenseTypeDefinitionProvider.cs | 100.00% <100.00%> (ø) |
|
...s/LicenseType/CddlLicenseTypeDefinitionProvider.cs | 100.00% <100.00%> (ø) |
|
...es/LicenseType/EplLicenseTypeDefinitionProvider.cs | 100.00% <100.00%> (ø) |
|
...s/LicenseType/EuplLicenseTypeDefinitionProvider.cs | 100.00% <100.00%> (ø) |
|
... and 10 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9f1c981...b11d71c. Read the comment docs.
There's currently an issue with the package OpenMcdf
(https://opensource.org/licenses/MPL-2.0
) which is receiving the following types: GPL-1.0, GPL-2.0, GPL-3.0, LGPL-2.1, MPL-1.1, MPL-2.0, AGPL-1.0, AGPL-3.0
, which is not right. It should only have MPL-2.0
!
Similar issues:
NetOffice.Core 1.7.4.4 Yes MIT, GPL-2.0, Apache-1.1, ISC, MS-PL, Zlib http://choosealicense.com/licenses/mit/
NetOffice.Outlook 1.7.4.4 Yes MIT, GPL-2.0, Apache-1.1, ISC, MS-PL, Zlib http://choosealicense.com/licenses/mit/
Following packages cannot be resolved: Elasticsearch.Net
, NEST
, Purplelight.Framework.Autofac.Integration.WebApi
(no text and no types)
DevExpress cannot be resolved with the URL https://www.devexpress.com/Support/EULAs/
And these Microsoft Packages cannot be resolved:
Microsoft.AspNet.Razor 3.0.0 Types
Microsoft.AspNet.WebApi.Client 5.2.7 Types
Microsoft.AspNet.WebApi.Core 5.2.7 Types
Microsoft.AspNet.WebApi.Owin 5.2.7 Types
Microsoft.AspNet.WebApi.Tracing 5.2.7 Types
Microsoft.CodeAnalysis.Common 2.3.1 Types
Microsoft.CodeAnalysis.CSharp 2.3.1 Types
Microsoft.Owin.Host.SystemWeb 2.1.0 Types
Microsoft.Owin.Security 2.1.0 Types
📫 Addressed Issue(s)
📄 Description
Implement the ability to get the license-type from the license-text if that one could be determined, because the license-type currently is the only thing that cannot be determined every time.
ILicenseInformationSource
for getting the type from the textLicenseTypeDefinition
in settingsLicenseTypeDefinition
in settingsLicenseTypeDefinition
as JSON FilePopularLicensesLicenseTypeDefinitionProvider
up into smaller pieces✅ Checks