hand sample checkbox not changing filters in Chrome

wgnhs / lslc-web-app

Web Application for the viewing the WGNHS Lake Superior Legacy Collection

https://wgnhs.github.io/lslc-web-app/

1 stars 0 forks source link

hand sample checkbox not changing filters in Chrome #63

Closed cmrRose closed 7 years ago

cmrRose commented 7 years ago

This problem occurs in Chrome for me , but not in Firefox. When I check/uncheck the Hand Sample Available filter, it doesn't trigger a change in the filters or re-deploy the query.

cmrRose commented 7 years ago

I confirmed via a JSBin that the input event is not triggered by a checkbox in Chrome. Appears to be the case in Safari as well. http://jsbin.com/pujubigofe/edit?html,js,console,output

cmrRose commented 7 years ago

The 'change' event does happen when the checkbox is checked/unchecked. For text inputs, a 'change' event only happens after they lose focus. We have a few options:

listen for change events on the checkboxes only, while listening for 'input' events on non-checkbox inputs only. (with or without a delay after a checkbox change??)
listen for only the 'change' event (must un-focus a text input)
add a button for the user to start the query

cmrRose commented 7 years ago

Although we may be undecided on user interface decisions (delay or no delay, add a button?), this issue should be closed since I've figured out how to implement these options.