wgois / OIS

Official OIS repository. Object oriented Input System
https://wgois.github.io/OIS/
zlib License
254 stars 87 forks source link

OSX Non Exclusive Mouse #12

Closed VENTDEV closed 6 years ago

VENTDEV commented 8 years ago

Adds support for non exclusive mouse mode for OSX.

Use Param “MacNonexclusiveMouse”

Ybalrid commented 6 years ago

@VisualEntertainmentAndTechnologies it looks like the changes in #12 and #13 are somewhat entangled. Also for some reason, you have changed the UNIX permission numbers on a bunch of files, and this PR as undesired side effect like moving copy (or move) constructors definitions around.

I'm probably not going to both attempting to merge theses. code has diverged from the time you authored them and the PR aren't clean enough to salvage your fixes from them.

If you have the possibility, can you attempt to "forward port" (I'm inventing words here) the fixes on top of the current HEAD of the master branch? This would be great, but I understand you probably have better things to do... ;-)

I'm going to close #12 and close #13 for now, as I don't thing I can get anything useful out of them.

VENTDEV commented 6 years ago

Looks like some how I screwed up the PR's moving them from my SVN to this GIT. Sorry about that. I dont' recall why permissions were changed. Most likely it had something to do with getting the files to work with Codeblocks in OSX. Apple loves to make life difficult if you don't want to use their crap.

Anyhoo, as for this PR, it's probably best to burry it and focus on getting Coca/64bit support on OSX. Carbon and 32-bit are EOL and will most likely be removed in the next OSX release.

Ybalrid commented 6 years ago

Oh. Well, current code is usung cocoa, but i woukd need hekp from somebody having a mac to validate if it actualky works. I am setting up a VM wuth high sierra but it’s a reak hassle ;-)

-- Arthur Brainville (Ybalrid) ESIEA 4A http://esiea.fr/

Le 25 mars 2018 à 07:10, VisualEntertainmentAndTechnologies notifications@github.com a écrit :

Looks like some how I screwed up the PR's moving them from my SVN to this GIT. Sorry about that. I dont' recall why permissions were changed. Most likely it had something to do with getting the files to work with Codeblocks in OSX. Apply loves to make life difficult if you don't want to use their crap.

Anyhoo, as for this PR, it's probably best to burry it and focus on getting Coca/64bit support on OSX. Carbon and 32-bit are EOL and will most likely be removed in the next OSX release.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

VENTDEV commented 6 years ago

Unfortunately my program is 32 bit and uses carbon. It will be some time before I attempt at porting it over to cocoa. So I won't be able to do any testing/feedback on this for several months.

Ybalrid commented 6 years ago

Okay, noted. I haven't dug through the code yet, I don't know if Carbon support is still present of it it was removed in the patch that implement Cocoa (I don't see a good reason they would have)