wgois / OIS

Official OIS repository. Object oriented Input System
https://wgois.github.io/OIS/
zlib License
254 stars 86 forks source link

Additional Left/Right Modifiers + Win #61

Closed nolan778 closed 4 years ago

nolan778 commented 4 years ago

Summary of changes

Only affects Win32KeyBoard, as I'm unfamiliar with how to make similar changes in the other keyboards.

With left and/or right modifiers active, the combined modifier is also active. Both left/right must be inactive for the combined modifier to deactivate. This should only affect client code if they are comparing the entire bit field. However, the function to return the full bit field did not exist before this pull request.

Ybalrid commented 4 years ago

I'm gonna take a look at this. Somehow GitHub is not sending to me all the notifications from this repository and I did not see this PR

Ybalrid commented 4 years ago

This looks fine to me. I will test these, and either merge this right away, or try to add these modifiers at least on the Linux/X side myself

Ybalrid commented 4 years ago

I'm happy with this!