search

wgtdkp / wgtcc

A small C11 compiler
MIT License
765 stars 130 forks source link

switch build system from cmake to make #55

Closed rofl0r closed 5 years ago

wgtdkp commented 5 years ago

see this PR#53, I have just switched build system from make to cmake...

rofl0r commented 5 years ago

i know, my PR reverts that. i figured if you would merge any PR introducing bad & bloated build systems without even having a discussion (obviously there was no need for that), you might as well simply merge a PR reverting it back to a good build system.

wgtdkp commented 5 years ago

Thanks for your contribution and consideration. I of cause didn't merge any PR without discussion. The change of PR#53 is discussed and reviewed outside of GitHub platform.

For which build system (make vs cmake) is better, I think, it is a personal taste. The reason why I switched to cmake is simply that I always prefer the newer one and just want to give a try.

rofl0r commented 5 years ago

here's a couple reasons why cmake sucks: https://github.com/libtom/libtomcrypt/issues/391#issuecomment-390434739 you might also be interested in my in-depth primer about build systems http://sabotage-linux.github.io/blog/5/