search

whai362 / PVT

Official implementation of PVT series
Apache License 2.0
1.73k stars 246 forks source link

About `patch_size` in pvt_v2 #72

Closed abhi-glitchhg closed 3 years ago

abhi-glitchhg commented 3 years ago

Hey there! I read your paper and have gone through the code; amazing work!

While going through the code I noticed that we are not using patch_size variable in PyramidVisionTransformerV2 class; patch_size is either 7 or 3; but we are not using patch_size variable anywhere in the class Link

But in many register_model decorators, you have used patch_size as 4 link

So whether V2 is always supposed to use 7 for first stage and 3 for the rest stages;

Could you clarify this?

czczup commented 3 years ago

Hey there! I read your paper and have gone through the code; amazing work!

While going through the code I noticed that we are not using patch_size variable in PyramidVisionTransformerV2 class; patch_size is either 7 or 3; but we are not using patch_size variable anywhere in the class Link

But in many register_model decorators, you have used patch_size as 4 link

So whether V2 is always supposed to use 7 for first stage and 3 for the rest stages;

Could you clarify this?

Hi, please refer to this code: link The patch_size of pvtv2 is [7, 3, 3, 3], the patch_size=4 is unused, we will fix this.

abhi-glitchhg commented 3 years ago

Great thanks! Will look into the code