Can I contribute to the post-processing?

whai362 / pan_pp.pytorch

Official implementations of PSENet, PAN and PAN++.

Apache License 2.0

435 stars 90 forks source link

Can I contribute to the post-processing? #114

Closed Zerohertz closed 1 year ago

Zerohertz commented 1 year ago

Dear Mr. Wang

After reading your paper, I noticed that post-processing code takes up most of the time during model execution. Therefore, I improved the post-processing code as below and confirmed that it is faster than the existing post-processing module.

May I send you a pull-request to contribute to this repository?

seekingdeep commented 1 year ago

Peace Be Upon You, it is better that you send the pull request, and allow the developer to have a look.

Also, i have seen the benchmarks that you posted, but what is the percentage of improvement from the original processing against yours

Zerohertz commented 1 year ago

Thank you for your comments.

Based on your comment, I will quantitatively evaluate the improvement through the two post-processing function (pa.pyx) and make a pull request for it.