search

whaleygeek / SL030

A driver package for the SL030 RFID tag reader
MIT License
0 stars 1 forks source link

Consider just using standard I2C and ditch the low level software #7

Closed whaleygeek closed 3 years ago

whaleygeek commented 3 years ago

When this was written, there wasn't a good I2C driver around. Now there is. Might just look at significantly simplifying this and building on top of the standard I2C stack as that has good support now and is in all the latest OSes. That might also fix a ton of issues to do with GPIO sharing etc.

Specifically, extracting the command logic into a class/module that implements the protocol, independent of the physical connection, would be a good way to enable this - i.e. instead of just passing in a GPIO object, pass in a I2C object and a GPIO object, making the SL030 driver part completely oblivious to the actual physical implementation (currently it receives a passed-in GPIO object and assumes a direct link to the low level ci2c ctypes python wrapper, which tightly binds it to a specific physical layer).

whaleygeek commented 3 years ago

Should deal with this over here first: https://github.com/whaleygeek/softbus