search

whame / tmux-modal

Execute complex tmux commands in just a few keystrokes with a modal mode that is designed to be efficient, easy to remember and comfortable
MIT License
172 stars 4 forks source link

Modal mode indicator shown twice #4

Closed farzadmf closed 2 years ago

farzadmf commented 2 years ago

I'm using powerline for my status bar, and it happens a lot that I see two equal signs in the status bar when I enable the modal mode. If I restart my tmux session, it goes back to only one.

What I see now: image

What I see when I end my tmux session and start a new one: image

whame commented 2 years ago

What are the steps before you see two icons? The only way I can see that this happens is if somehow tmux-modal is loaded twice (or more)

farzadmf commented 2 years ago

I think I was able to reproduce by using tpm' s Uupdate function.

Basically:

whame commented 2 years ago

I just tried to reproduce with your steps, but I couldn't trigger it. Can you trigger this consistently with your reproducing steps?

I wonder if something else in your config causes this. Would it be possible for instance to comment out any other plugins and see if it still happens?

farzadmf commented 2 years ago

OK, good to know, TBH, I was a bit hesitent to create the issue as I thought it might have something to do with my setup.

I have a bunch of plugins installed, so I'll try to see if something is clashing with other plugins

whame commented 2 years ago

The output of 

tmux show-options -g status-left

might be helpful here as well. Save the output after a fresh session, and then when you trigger it, run the command again and paste the output so we can compare.

whame commented 2 years ago

I figured that we could be more robust if we only set the status bar once. It is better to not trust the environment to only load tmux-modal once. I just pushed a fix, please update and try it. We should be able to close this issue. Thank you for reporting this!

farzadmf commented 2 years ago

Nice! thank you for being so fast at looking at the issues.

Updated and it seems like the issue is fixed. I noticed that, for some reason, I wasn't able to get out of modal mode (or maybe I was out of it but the = was still there), but I haven't been able to reproduce.

I'll create a new issue if I see that happening, and gonna close this one

Again, well done with the plugin and the fast support to fix issues. Keep up the good work